-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support to scan config resources with applicable policies & Refactors filteration #803
Conversation
patilpankaj212
commented
May 21, 2021
- Better Rego Metadata filters and unit tests
- Scan config resources with only applicable polices
Codecov Report
@@ Coverage Diff @@
## master #803 +/- ##
==========================================
+ Coverage 78.22% 78.32% +0.09%
==========================================
Files 162 164 +2
Lines 4354 4382 +28
==========================================
+ Hits 3406 3432 +26
- Misses 734 735 +1
- Partials 214 215 +1
|
03e018c
to
9615097
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall its a good refactor! Requested some minor changes.
We can also add the phrase "Filtering Refactor" in the PR title. |
9615097
to
fde1435
Compare
* policy type filter added * variable name issue fixed 1. cloud type --> policytypes
fde1435
to
9ed3dcc
Compare
9ed3dcc
to
e673b2f
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |