container funcs to return dev friendly warnings #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -100,15 +100,15 @@ func fetchContainersFromAwsResource(resource jsonObj, hclBody *hclsyntax.Body, r | |||
| } | |||
| fileData, err := ioutil.ReadFile(fileLocation) | |||
| if err != nil { | |||
| zap.S().Errorf("error fetching containers from aws resource: %v", err) | |||
| zap.S().Warnf("error fetching containers from aws resource: %v", err) | |||
There was a problem hiding this comment.
if it is just a warning, we probably shouldn't return the control. Also the messages clearly says error
Codecov Report
@@ Coverage Diff @@
## master #1319 +/- ##
=======================================
Coverage 77.39% 77.39%
=======================================
Files 277 277
Lines 7813 7813
=======================================
Hits 6047 6047
Misses 1406 1406
Partials 360 360
|
Rchanger
reviewed
Jul 26, 2022
| @@ -126,7 +126,7 @@ func getContainersFromhclBody(hclBody *hclsyntax.Body) (results []output.Contain | |||
| for _, arg := range funcExp.Args { | |||
| re, diags := arg.Value(nil) | |||
| if diags.HasErrors() { | |||
| zap.S().Errorf("error fetching containers from aws resource: %v", getErrorMessagesFromDiagnostics(diags)) | |||
| zap.S().Warnf("error fetching containers from aws resource: %v", getErrorMessagesFromDiagnostics(diags)) | |||
There was a problem hiding this comment.
@gaurav-gogia let's change this msg as well, instead of error fetching container make it failed to fetch the container since we are making it a warning keeping the error message will create confusion. WDYT
|
Kudos, SonarCloud Quality Gate passed!
|
nasir-rabbani
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.