Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding CFT support for new resources #1293

Merged
merged 3 commits into from
Jun 13, 2022
Merged

Adding CFT support for new resources #1293

merged 3 commits into from
Jun 13, 2022

Conversation

shreyas-phansalkar-189
Copy link
Contributor

Adding CFT support for following resources:

  • AWS Subnet
  • AWS Nat Gateway
  • AWS Route Table
  • AWS Route Table Association
  • AWS Route

@shreyas-phansalkar-189
Adding CFT support for following resources:
b70db14 
- AWS Subnet
- AWS Nat Gateway
- AWS Route Table
- AWS Route Table Association
- AWS Route
@shreyas-phansalkar-189 shreyas-phansalkar-189 requested a review from a team as a code owner June 13, 2022 04:42
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2022 •
edited
Loading

Codecov Report

Merging #1293 (86a9b39) into master (c729550) will increase coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1293      +/-   ##
==========================================
+ Coverage   77.20%   77.39%   +0.18%     
==========================================
  Files         272      277       +5     
  Lines        7748     7813      +65     
==========================================
+ Hits         5982     6047      +65     
  Misses       1406     1406              
  Partials      360      360
Impacted Files Coverage Δ
pkg/mapper/iac-providers/cft/cft.go 89.69% <100.00%> (+0.56%) ⬆️
pkg/mapper/iac-providers/cft/config/nat-gateway.go 100.00% <100.00%> (ø)
...ac-providers/cft/config/route-table-association.go 100.00% <100.00%> (ø)
pkg/mapper/iac-providers/cft/config/route-table.go 100.00% <100.00%> (ø)
pkg/mapper/iac-providers/cft/config/route.go 100.00% <100.00%> (ø)
pkg/mapper/iac-providers/cft/config/subnet.go 100.00% <100.00%> (ø)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

patilpankaj212
patilpankaj212 approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@patilpankaj212 patilpankaj212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patilpankaj212 patilpankaj212 merged commit 00664bc into tenable:master Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patilpankaj212 patilpankaj212 patilpankaj212 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shreyas-phansalkar-189 @codecov-commenter @patilpankaj212