fixes: panic in case of zap logger init on windows os #1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/logging/logger.go
Outdated
| } | ||
|
|
||
| // create zap logger | ||
| // should we panic here? |
There was a problem hiding this comment.
I think we should panic if we cannot create logger, or, propagate error back and exit with error message.
Codecov Report
@@ Coverage Diff @@
## master #1283 +/- ##
==========================================
- Coverage 77.37% 77.20% -0.17%
==========================================
Files 272 272
Lines 7731 7748 +17
==========================================
Hits 5982 5982
- Misses 1390 1406 +16
- Partials 359 360 +1
|
Rchanger
force-pushed
the
zap_file_panic_fix_window
branch
from
5258d6c to
201f64c
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.