Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

Switch to upstream SQLite driver #9

Merged
merged 1 commit into from
Oct 9, 2021
Merged

Conversation

jlegrone
Copy link
Collaborator

@jlegrone jlegrone commented Oct 8, 2021

What changed?

This PR removes SQLite driver code that has been recently moved to temporalio/temporal.

Why?

The upstream driver code is now being tested alongside each change to the Temporal server codebase, which will help ensure stability and compatibility across version upgrades.

How did you test it?

Automated tests in CI

Potential risks

This change removes support for non-cgo builds, and there's no guarantee that this will be added back upstream.

Is hotfix candidate?

No

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2021

Codecov Report

Merging #9 (399cfa1) into main (3b71bff) will increase coverage by 4.14%.
The diff coverage is 63.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   43.21%   47.35%   +4.14%     
==========================================
  Files          26       11      -15     
  Lines        2203      606    -1597     
==========================================
- Hits          952      287     -665     
+ Misses       1188      302     -886     
+ Partials       63       17      -46     
Impacted Files Coverage Δ
cmd/temporalite/main.go 2.19% <0.00%> (ø)
temporaltest/logger.go 73.33% <ø> (ø)
server.go 69.49% <53.84%> (-4.98%) ⬇️
internal/liteconfig/config.go 90.29% <100.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b71bff...399cfa1. Read the comment docs.

@jlegrone jlegrone force-pushed the jlegrone/upstream-driver branch from 55c8d51 to 399cfa1 Compare October 9, 2021 03:00
@jlegrone jlegrone merged commit b2bcb51 into main Oct 9, 2021
@jlegrone jlegrone deleted the jlegrone/upstream-driver branch October 9, 2021 03:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants