This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
Goreleaser cross compile #74
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The config for cross-compilation may be simpler after we update to the latest release of Temporal server, since the sqlite driver no longer requires CGO. We can keep this PR open until we've updated, then reasses what changes are needed to the goreleaser config. |
|
#89 is merged, and we no longer require CGO in order to build! I think we should be able to stick with the goreleaser defaults now, so I'll close this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
I noticed that the goreleaser did nothing, most likely because of the annoyance involved in cross compilation.
Why?
I did this so release binaries would be available for multiple platforms
How did you test it?
I created releases in my own repository. I tested some, but not all, of the binaries on various machines I have. I can confirm the darwin arm64, windows amd64, and linux amd64 binaries work.
Potential risks
There should be little risk in this because it doesn't change the code, but the binaries could be broken.
Is hotfix candidate?
No