This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Updates the
temporalite
CLI to always use dynamic ports.Why?
Previously ports for internal APIs were assigned by adding a hardcoded offset to the frontend grpc port. About 10 ports are computed in this way, leading to a high chance of conflicts.
Closes #34.
How did you test it?
Potential risks
Some users may have been depending on the previous behavior, since pprof and metrics ports were predictable (though this was never documented). Explicit flags for setting those ports can be added later.
Is hotfix candidate?
No