This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
I'm adding a new server option
WithUpstreamOptions(options ...temporal.ServerOption)
enabling users to configure the Temporal server more granularly., e.g.:Why?
This allows users configuring all server options, like InterruptOn, without the maintenance burden of having dedicated functions.
How did you test it?
Tested locally.
Potential risks
This is a backward incompatible change. Before,
temporal.InterruptOn(temporal.InterruptCh())
was used. This pull request proposes to leave the interrupt option undefined to match Temporal's default.Is hotfix candidate?