Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

Support dynamic config values via CLI #127

Closed
cretz opened this issue Sep 13, 2022 · 0 comments
Closed

Support dynamic config values via CLI #127

cretz opened this issue Sep 13, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@cretz
Copy link
Member

cretz commented Sep 13, 2022

Is your feature request related to a problem? Please describe.

Right now it's very hard to set dynamic config values

Describe the solution you'd like

  • Allow dynamic config values to be set via the CLI (probably overrides the entire dynamic config the user may have
  • Set, by default, the system.forceSearchAttributesCacheRefreshOnRead dynamic config value as true which disables the search attribute cache

This should probably wait on 1.18 when the dynamicconfig.Client gets greatly simplified down to one method (already the case in master).
@cretz cretz added the enhancement New feature or request label Sep 13, 2022
@cretz cretz mentioned this issue Sep 20, 2022
Merged
cretz added a commit to cretz/temporalite that referenced this issue Sep 21, 2022
@cretz
CLI dynamic config and default search attribute cache disabled
9ea176b 
Fixes temporalio#127
@cretz cretz closed this as completed in a3d9d73 Sep 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cretz