Change search attribute validator to expect field names instead of alias #3398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Changed search attribute validator to expect the map to contain field names instead of alias.
Changed error type in
ValidateSizetoserviceerror.InvalidArgumentso it can go through gRPC correctly.Fixed the validation for upsert search attribute as it was merging a map with field names with a map with alias names.
Why?
ValidateSizeshould be for field names instead of alias since field names are the values to be stored. In order to be consistent,Validatewas also changed to expect the same input.How did you test it?
Updated unit tests.
Potential risks
Small search attribute alias might increase in size as being mapped to field name, and fail the size validation.
Is hotfix candidate?
No.