Bypass namespace validator for DescribeNamespace API #3336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
reviewed
Sep 8, 2022
| return nil, ErrNamespaceNotSet | ||
| } | ||
| return ni.namespaceRegistry.GetNamespace(namespaceName) | ||
| // Special case for DescribeNamespace API which can get namespace by Id and should bypass namespace registry. |
There was a problem hiding this comment.
update comments: // always pass validation for DescribeNamespace API calls.
alexshtin
force-pushed
the
feature/describe-namespace-bypass-validator
branch
from
ceaf0c5 to
12cea83
Compare
alexshtin
force-pushed
the
feature/describe-namespace-bypass-validator
branch
from
12cea83 to
daba691
Compare
yiminc
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Bypass namespace validator for
DescribeNamespaceAPI.Why?
DescribeNamespacereturns namespace information directly from database bypassing namespace registry. But namespace validator still validates namespace using registry. If there is something wrong with namespace registry it is impossible to read namespace information for debugging.How did you test it?
Modified existing tests.
Potential risks
No risks.
Is hotfix candidate?
No.