Improve batcher workflow metrics #3306
Conversation
common/dynamicconfig/constants.go
Outdated
| @@ -91,6 +91,8 @@ const ( | |||
| EnableActivityEagerExecution = "system.enableActivityEagerExecution" | |||
| // NamespaceCacheRefreshInterval is the key for namespace cache refresh interval dynamic config | |||
| NamespaceCacheRefreshInterval = "system.namespaceCacheRefreshInterval" | |||
| // EnableBatcherPerNamespaceWorker decides whether start batcher worker per namespace | |||
| EnableBatcherPerNamespaceWorker = "system.enableBatcherPerNamespaceWorker" | |||
There was a problem hiding this comment.
maybe
| EnableBatcherPerNamespaceWorker = "system.enableBatcherPerNamespaceWorker" | |
| EnableBatcher = "system.enableBatcher" |
?
There was a problem hiding this comment.
I see the per namespace worker flag changed to worker count. I assume the worker count could use to disable the per ns worker if the count set to 0. So I don't need this per ns worker flag and I just follow the scheduler to have a separate flag in frontend.
There was a problem hiding this comment.
It's still possible to enable/disable each worker component (scheduler, batcher) per-namespace, even though you can't change the count. So we could have another dynamic config for that. I don't feel strongly either way.
Co-authored-by: David Reiss <dnr@dnr.im>
This reverts commit 0337c18.
Makefile
Outdated
| @@ -117,7 +117,7 @@ update-mockgen: | |||
|
|
|||
| update-proto-plugins: | |||
| @printf $(COLOR) "Install/update proto plugins..." | |||
| @go install github.com/temporalio/gogo-protobuf/protoc-gen-gogoslick@latest | |||
There was a problem hiding this comment.
I released new version of plugin. Please revert this change and rebase after #3300 is merged.
There was a problem hiding this comment.
Sure. I reverted the commit and wait for the PR to merge.
This reverts commit 82d2f9f.
What changed?
Why?
Improve batcher workflow metrics
How did you test it?
Local test
Potential risks
Is hotfix candidate?