Multi-cursor: pending task count monitoring & mitigation #3275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
commented
Aug 29, 2022
yiminc
reviewed
Aug 30, 2022
| } else { | ||
| nextReader = readerGroup.NewReader(readerID+1, splitSlices...) | ||
| } | ||
| nextReader.Pause(clearSliceThrottleDuration) |
There was a problem hiding this comment.
Because we just did an unloading, without pause those tasks may be loaded back immediately.
Although nextReader will use a lower max task count so it won't trigger another unloading, but I think it will still increase the chance of another unloading. So pausing for a while and let some in memory tasks get processed first before attempting another load.
| AlertType AlertType | ||
| AlertAttributesReaderStuck *AlertAttributesReaderStuck | ||
| AlertType AlertType | ||
| AlertAttributesQueuePendingTaskCount *AlertAttributesQueuePendingTaskCount |
There was a problem hiding this comment.
nit: remove Queue from the type name and variable name?
There was a problem hiding this comment.
Added Queue in the names since we may/will monitor # of pending tasks on a host level in the future, so want to avoid naming confusion when we do that.
yiminc
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?
Potential risks
Is hotfix candidate?