Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shorten timeout used for recording task started #3268

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Shorten timeout used for recording task started #3268

merged 1 commit into from
Aug 25, 2022

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Aug 25, 2022

What changed?

  • Use shorter timeout for recording workflow/activity task started.

Why?

  • Please check in-line comment in the PR. Main idea is currently is using long poll context timeout which is too long.

How did you test it?

Potential risks

Is hotfix candidate?

@yycptt yycptt requested a review from yiminc August 25, 2022 01:38
@yycptt yycptt requested a review from a team as a code owner August 25, 2022 01:38
@yycptt yycptt merged commit 6c638c0 into temporalio:master Aug 25, 2022
@yycptt yycptt deleted the record-start-timeout branch August 25, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiminc yiminc yiminc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yycptt @yiminc