Multi-cursor: fix scheduled task precision issue #3255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
reviewed
Aug 19, 2022
| // This however, moves task visibility time forward for 1ms and may cause timer tasks to be skipped | ||
| // during processing. To compensate for that, add 1ms back when scheduling the task in reader.go. | ||
| for _, task := range resp.Tasks { | ||
| task.SetVisibilityTime(task.GetVisibilityTime().Truncate(scheduledTaskPrecision)) |
There was a problem hiding this comment.
does it make sense to handle this in task deserializer? Or even truncate the visibility time before we encode it into blob?
yiminc
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?
Potential risks
Is hotfix candidate?