Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not enqueue replication task to DLQ if shard shutdown #3245

Merged
merged 2 commits into from
Aug 19, 2022
Merged

Do not enqueue replication task to DLQ if shard shutdown #3245

merged 2 commits into from
Aug 19, 2022

Conversation

wxing1292
Copy link
Contributor

@wxing1292 wxing1292 commented Aug 18, 2022

What changed?

  • Do not enqueue replication task to DLQ if shard shutdown

Why?
Avoid unnecessary noise

How did you test it?
N/A

Potential risks
N/A

Is hotfix candidate?
Yes

@wxing1292 wxing1292 requested a review from a team as a code owner August 18, 2022 16:35
@wxing1292 wxing1292 enabled auto-merge (squash) August 18, 2022 16:35
@wxing1292 wxing1292 merged commit 6688c25 into temporalio:master Aug 19, 2022
@wxing1292 wxing1292 deleted the shard-close branch August 19, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants