Prioritize task loading persistence requests #3217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
commented
Aug 12, 2022
yiminc
reviewed
Sep 7, 2022
yycptt
force-pushed
the
prioritize-task-loading
branch
from
51ba63a to
b8ce0a6
Compare
yycptt
commented
Sep 8, 2022
| ) | ||
|
|
||
| func NewPriorityRateLimiter( | ||
| namespaceMaxQPS PersistenceNamespaceMaxQps, | ||
| hostMaxQPS PersistenceMaxQps, | ||
| requestPriorityFn quotas.RequestPriorityFn, |
There was a problem hiding this comment.
Taking it as an input so the logic can be substitute if needed.
| // dynamic config. | ||
| p.ConstructHistoryTaskAPI("GetHistoryTasks", tasks.CategoryTransfer): 2, | ||
| p.ConstructHistoryTaskAPI("GetHistoryTasks", tasks.CategoryTimer): 2, | ||
| p.ConstructHistoryTaskAPI("GetHistoryTasks", tasks.CategoryVisibility): 2, |
There was a problem hiding this comment.
Excluded replication get history tasks from being prioritized.
| // persistence metrics client. For now, it's only used by rate | ||
| // limit client, and we don't really care about the actual value | ||
| // returned, as long as they are different from each task category. | ||
| func ConstructHistoryTaskAPI( |
There was a problem hiding this comment.
persistence retry/metrics/ratelimit client should be moved to persistence/client package. Then this function doesn't have to be exported.
yycptt
commented
Sep 8, 2022
| @@ -42,6 +42,10 @@ import ( | |||
| "go.uber.org/fx" | |||
| ) | |||
|
|
|||
| const ( | |||
| timerQueuePersistenceMaxRPSRatio = 0.3 | |||
There was a problem hiding this comment.
the actual usage is much low than this, so it should be quite safe.
yiminc
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?
Potential risks
Is hotfix candidate?