Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to unix time 0, instead of time.Time{} #3213

Merged
merged 2 commits into from
Aug 11, 2022
Merged

Default to unix time 0, instead of time.Time{} #3213

merged 2 commits into from
Aug 11, 2022

Conversation

wxing1292
Copy link
Contributor

What changed?

  • Default to unix time 0, instead of time.Time{}

Why?
UnixNano of time.Time is not well defined

Note that this means the result of calling UnixNano on the zero Time is undefined.

How did you test it?
N/A

Potential risks
N/A

Is hotfix candidate?
N/A

@wxing1292 wxing1292 marked this pull request as ready for review August 11, 2022 00:17
@wxing1292 wxing1292 requested a review from a team as a code owner August 11, 2022 00:17
@wxing1292 wxing1292 enabled auto-merge (squash) August 11, 2022 00:22
@wxing1292 wxing1292 merged commit aadbbac into temporalio:master Aug 11, 2022
@wxing1292 wxing1292 deleted the unix-time branch August 11, 2022 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiminc yiminc yiminc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wxing1292 @yiminc