Push serialization of history branch from history manager down to history store #3205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norberthu
force-pushed
the
new-history-branch
branch
from
194903c to
fe661df
Compare
yycptt
reviewed
Aug 10, 2022
| var err error | ||
| resp.BranchToken, err = NewHistoryBranchToken(request.TreeId) | ||
| return resp, err | ||
| req := &NewHistoryBranchRequest{ |
There was a problem hiding this comment.
nit: is this the same as the request parameter? resp is also the same?
There was a problem hiding this comment.
good catch! For the longest time I actually had a parallel Internal- prefixed struct and decided last minute that was unnecessary for this particular function. I'll clean this up
|
Regarding rate limiting and retryable for |
yux0
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?
Potential risks
Is hotfix candidate?