Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default consistency level for visibility DeleteWorkflowExecution #3132

Merged
merged 2 commits into from
Jul 26, 2022
Merged

Use default consistency level for visibility DeleteWorkflowExecution #3132

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c9695c
changing visibility store consistency from goCql.One to as provided i…
dhruva-groww Jul 22, 2022
ee04055
updates
dhruva-groww Jul 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/persistence/visibility/store/standard/cassandra/visibility_store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ func NewVisibilityStore(

return &visibilityStore{
session: session,
lowConslevel: gocql.One,
lowConslevel: gocql.Consistency(cfg.Consistency.GetConsistency()),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhruva-groww, is there specific issue that you are encountered with this?
The consistency level One is used intentionally as lowConslevel for read operations. I'm not sure why the Delete operation is also using this lowConslevel, is it the one that is causing trouble?
cc @alexshtin @rodrigozhou

Copy link
Contributor Author

@dhruva-groww dhruva-groww Jul 22, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I assumed the writes that occur should occur as per the configuration provided in config (default as local_quorum) under visibility store.
I discovered this issue while integrating with DataStax which does not allow ONE as a consistency level while writing (as a good practice as it may cause data loss). I had raised it here with logs and exceptions
https://community.temporal.io/t/getting-error-on-deleting-workflows-while-using-astradb-serverless-with-temporal/5356

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of changing the lowConslevel here, could you change the DeleteWorkflow to not use consistency One?

temporal/common/persistence/visibility/store/standard/cassandra/visibility_store.go

Line 477 in d56e1d6

if err := query.Consistency(v.lowConslevel).Exec(); err != nil {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On it

}, nil
}

Expand Down