Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat protoc warnings as errors #3113

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Treat protoc warnings as errors #3113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ This doc is for contributors to Temporal Server (hopefully that's you!)
- Install on Ubuntu with `sudo apt install golang`.
* [Protocol buffers compiler](https://github.com/protocolbuffers/protobuf/) (only if you are going to change `proto` files):
- Install on macOS with `brew install protobuf`.
- Install on Ubuntu with `sudo apt install protobuf-compiler`.
- Download all other versions from [protoc release page](https://github.com/protocolbuffers/protobuf/releases).
* [Temporal CLI tctl](https://github.com/temporalio/tctl)
- Homebrew `brew install tctl`
- Go install `make update-tctl`
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ protoc: $(PROTO_OUT)
@printf $(COLOR) "Build proto files..."
# Run protoc separately for each directory because of different package names.
$(foreach PROTO_DIR,$(PROTO_DIRS),\
protoc $(PROTO_IMPORTS) \
protoc --fatal_warnings $(PROTO_IMPORTS) \
--gogoslick_out=Mgoogle/protobuf/descriptor.proto=github.com/golang/protobuf/protoc-gen-go/descriptor,Mgoogle/protobuf/duration.proto=github.com/gogo/protobuf/types,Mgoogle/protobuf/wrappers.proto=github.com/gogo/protobuf/types,Mgoogle/protobuf/timestamp.proto=github.com/gogo/protobuf/types,plugins=grpc,paths=source_relative:$(PROTO_OUT) \
$(PROTO_DIR)*.proto \
$(NEWLINE))
Expand Down
Loading