Change a bunch of code to use generics #3078
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
common.Min/Max*
and functions and a few others to newcommon/util
package to prevent circular imports.slices.Clone
,slices.Contains
,maps.Clone
,maps.Copy
,maps.Keys
, andmaps.Values
fromgolang.org/x/exp
.common.CloneProto
and switch users ofproto.Clone
service/matching/tasks.go
can just useutil.SortSlice
I tried to keep this to only simple noncontroversial changes.
Why?
Clearer code
How did you test it?
Existing unit tests and integration tests
Potential risks
typos
Is hotfix candidate?
no