Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make queue max read level always exclusive #3036

Merged
merged 4 commits into from
Jun 30, 2022

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Jun 29, 2022

What changed?

  • Currently the returned queue max read level is inclusive for immediate queue (transfer, visibility, replication) but exclusive for scheduled queue (timer).
  • Follows the convention that a range is [inclusive, exclusive) and unify the behavior so that the returned max read level is always exclusive.

Why?

  • Unify behavior.
  • In multi cursor world, there's only one implementation of all queues (immediate or schedule) and if the interpretation of max read level is different, we need special logic in the queue impl to handle that.

How did you test it?

  • existing test.
  • local canary.

Potential risks

  • in worst case, the last task in immediate queue can't be loaded.

Is hotfix candidate?

  • no

@yycptt yycptt requested a review from wxing1292 June 29, 2022 19:38
@yycptt yycptt requested a review from a team as a code owner June 29, 2022 19:38
@yycptt yycptt merged commit e7c02d9 into temporalio:master Jun 30, 2022
@yycptt yycptt deleted the exclusive-max-read-level branch June 30, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants