Multi-cursor components: queue slice #2996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
reviewed
Jun 18, 2022
yiminc
reviewed
Jun 18, 2022
wxing1292
reviewed
Jun 21, 2022
wxing1292
reviewed
Jun 21, 2022
wxing1292
reviewed
Jun 21, 2022
wxing1292
reviewed
Jun 21, 2022
wxing1292
reviewed
Jun 21, 2022
wxing1292
reviewed
Jun 21, 2022
wxing1292
reviewed
Jun 21, 2022
wxing1292
reviewed
Jun 21, 2022
wxing1292
reviewed
Jun 27, 2022
wxing1292
reviewed
Jun 27, 2022
wxing1292
reviewed
Jun 27, 2022
wxing1292
reviewed
Jun 27, 2022
wxing1292
reviewed
Jun 27, 2022
|
|
||
| for idx, iterator := range iterators[:len(iterators)-1] { | ||
| nextIterator := iterators[idx+1] | ||
| if iterator.Range().ExclusiveMax.CompareTo(nextIterator.Range().InclusiveMin) >= 0 { |
There was a problem hiding this comment.
should this be > 0 instead of >= 0?
There was a problem hiding this comment.
Since iterator doesn't have predicate, two iterators should be merged together if one's max equals the other's min. As iterator.CanMerge() returns true in this case, I think the check should panic when we found they're not merged together. I can update the panic message to be more specific.
wxing1292
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?
Potential risks
Is hotfix candidate?