-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add elasticsearch cli tool #2977
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Alexander Mays <alex@eastside.io>
Signed-off-by: Alexander Mays <alex@eastside.io>
Signed-off-by: Alexander Mays <alex@eastside.io>
Signed-off-by: Alexander Mays <alex@eastside.io>
😮 this is great! I've never had time for it and honestly |
Hah, yea I'm trying to write a Terraform module that can deploy to an AWS stack with RDS + Opensearch. The necessary piece was #2830, but this will allow me to avoid having to wrap the Dockerfile or modify the helm-chart. I'll have to PR both of those with some adjustments I've made for these changes as well. |
This PR was marked as stale. Please update or close it. |
What changed?
ClusterPutSettings
andPing
methods added to the ES client wrappersWhy?
Currently, there are scripts referenced in the dockerfiles and the helm charts that rely on curl to create ES indices and poll for ES availability, e.g.
https://github.com/temporalio/docker-builds/blob/main/docker/auto-setup.sh#L245-L263
https://github.com/temporalio/docker-builds/blob/main/docker/auto-setup.sh#L265-L278
https://github.com/temporalio/temporal/blob/master/Makefile#L372-L377
https://github.com/temporalio/helm-charts/blob/master/templates/server-job.yaml#L281
https://github.com/temporalio/helm-charts/blob/master/templates/server-job.yaml#L288-L289
https://github.com/temporalio/helm-charts/blob/master/templates/server-deployment.yaml#L76
It would be better if there was a tool that leveraged the built-in temporal ES auth providers (#1011) and a place to put common ES operations
How did you test it?
Potential risks
Is hotfix candidate?
No