Remove hacky force flush buffer check #2439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove hacky force flush buffer bypass for XDC if incoming version -> current cluster NOTE: previously, this hacky bypass was added to allow workflow resend back to original cluster due to local DB dataloss. Removing this hacky bypass due to breaking basic NDC assumptions.
yux0
approved these changes
Jan 31, 2022
yiminc
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
NOTE: previously, this hacky bypass was added to allow workflow resend back to original
cluster due to local DB dataloss. Removing this hacky bypass due to breaking basic NDC
assumptions.
How did you test it?
N/A
Potential risks
N/A
Is hotfix candidate?
No