Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow remove cluster from namespace cluster list #2432

Merged
merged 1 commit into from
Jan 28, 2022
Merged

Allow remove cluster from namespace cluster list #2432

merged 1 commit into from
Jan 28, 2022

Conversation

yux0
Copy link
Contributor

@yux0 yux0 commented Jan 28, 2022

What changed?
Allow remove cluster from namespace cluster list

Why?
Allow remove cluster from namespace cluster list

How did you test it?

Potential risks

Is hotfix candidate?

@yux0 yux0 requested a review from a team January 28, 2022 20:26
yycptt
yycptt reviewed Jan 28, 2022
View reviewed changes
Copy link
Member

@yycptt yycptt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if we can ask for confirmation or show a warning for removing a cluster. But I guess that should be done on client/cli side.

@yux0 yux0 merged commit a7ab9a2 into temporalio:master Jan 28, 2022
@yux0 yux0 deleted the allow-remove-cluster branch January 28, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yycptt yycptt yycptt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yux0 @yycptt