Set git revision at build from env variable #2428
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Allows to set git revision at build from env variable
Why?
Github actions only fetch one commit of data for submodules and not git history, hence the build was throwing "not a git repository"
https://github.com/temporalio/docker-builds/runs/4975313307?check_suite_focus=true#step:7:321
There is an option to fetch git history but seems only for the root project and not the submodules, using
fetch_depth
param, see https://github.com/actions/checkout#checkout-v2How did you test it?
Potential risks
Is hotfix candidate?