Add RawTokenKeyProvider #2420
Merged
Add RawTokenKeyProvider #2420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
reviewed
Jan 26, 2022
| @@ -39,4 +41,11 @@ type TokenKeyProvider interface { | |||
| Close() | |||
| } | |||
|
|
|||
| // RawTokenKeyProvider is a TokenKeyProvider that provides keys for validating JWT tokens | |||
There was a problem hiding this comment.
Need to add comments that this is an optional alternative version of token key provider. However, if provider implements this interface, it will take precedent and shadow the implementation of TokenKeyProvider and be used to validate JWT token.
There was a problem hiding this comment.
If RawTokenKeyProvider is a TokenKeyProvider, shall we embed TokenKeyProvider inside RawTokenKeyProvider interface and only specify additional methods?
There was a problem hiding this comment.
I think it's fine as it is and there's no need to add TokenKeyProvider methods to RawTokenKeyProvider.
|
buildkite fail because you need to run |
sergeybykov
approved these changes
Jan 31, 2022
Add an empty line to make goimports happy.
yiminc
approved these changes
Jan 31, 2022
|
Thank you, @wenerme, for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
close #2382
Why?
How did you test it?
Potential risks
Is hotfix candidate?
No