Replace Cassandra visibility TTL with explicit DELETE #2387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
reviewed
Jan 18, 2022
Comment on lines
441
to
443
| // Primary key in closed_execution table has close_time which is not in the request. | ||
| // Query closed_execution table first (using secondary index by workflow_id) to get close_time. | ||
| // This is not very efficient if workflow has multiple executions. |
There was a problem hiding this comment.
I don't like this part, this is one extra read for every visibility delete. Did you try to put close_time into task?
There was a problem hiding this comment.
Changed. And I like new approach better than before.
Comment on lines
444
to
454
| query := v.session. | ||
| Query(templateGetClosedWorkflowExecutionsByID, | ||
| request.NamespaceID.String(), | ||
| namespacePartition, | ||
| persistence.UnixMilliseconds(minTime), | ||
| persistence.UnixMilliseconds(maxTime), | ||
| request.WorkflowID). | ||
| Consistency(v.lowConslevel) | ||
| iter := query.Iter() | ||
|
|
||
| wfExecution, has := readClosedWorkflowExecutionRecord(iter) |
There was a problem hiding this comment.
Does this query handles pagination as well? If workflowID is a cron, you could have many RunIDs.
There was a problem hiding this comment.
Not relevant anymore, but it turned out that default page size is 5000 (not unlimited, as I would expect it to be if not specified).
alexshtin
force-pushed
the
feature/remove-visibility-ttl
branch
from
dd9318c to
e35f5eb
Compare
alexshtin
force-pushed
the
feature/remove-visibility-ttl
branch
from
e35f5eb to
26aeb85
Compare
yiminc
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Replace Cassandra visibility TTL with explicit
DELETE.Why?
Previously visibility records were deleted only when retention kicked in. For new
DeleteWorklfowExecutionAPI it is required to be able to delete visibility record in any given moment of time.How did you test it?
Modify existing unit test. Will add integration tests for
DeleteWorkflowExecutionAPI in corresponding PR.Potential risks
If Cassandra based visibility is used and workflow has many executions, new implementation is slower. No production environments should use Cassandra based visibility though.No risks.
Is hotfix candidate?
No.