Option to enable forwarding all APIs #2367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
force-pushed
the
forward_all_apis
branch
from
a4f4e61 to
3839c51
Compare
wxing1292
reviewed
Jan 12, 2022
| @@ -71,6 +74,7 @@ type ( | |||
| currentClusterName string | |||
| config *Config | |||
| namespaceRegistry namespace.Registry | |||
| enableForAllAPIs bool | |||
wxing1292
approved these changes
Jan 12, 2022
paulnpdev
reviewed
Jan 12, 2022
| @@ -51,6 +51,9 @@ const ( | |||
| // 6. QueryWorkflow | |||
| // please also reference selectedAPIsForwardingRedirectionPolicyWhitelistedAPIs | |||
| DCRedirectionPolicySelectedAPIsForwarding = "selected-apis-forwarding" | |||
|
|
|||
| // DCRedirectionPolicyAllAPIsForwarding means forwarding all APIs based on namespace active cluster | |||
| DCRedirectionPolicyAllAPIsForwarding = "all-apis-forwarding" | |||
There was a problem hiding this comment.
If we have a redirection policy for Selected API forwarding, why isn't "redirect all" just a special case where they are all Selected?
There was a problem hiding this comment.
Yes, it is a flag in the implementation struct and everything is the same except when detecting if the called API is in the selected set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add option to enable forwarding for all APIs
Why?
So it is possible to forward all calls if needed during migration.
How did you test it?
unit test
Potential risks
No
Is hotfix candidate?
No