Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix queue diff metrics for disabled clusters #2329

Merged
merged 3 commits into from
Dec 29, 2021

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Dec 28, 2021

What changed?

  • Ignore disabled cluster when calculating queue diff metrics

Why?

  • Disabled clusters' ack level won't advance and they also won't prevent overall task queue ack level from advancing. If they are included in the calculation, the queue diff metrics will only keeping increasing, while there's actually no lag at all.

How did you test it?
Existing tests

Potential risks
N/A, just changing metrics

Is hotfix candidate?
No.

@yycptt yycptt requested review from wxing1292 and a team December 28, 2021 22:21
@yycptt yycptt merged commit 81ce604 into temporalio:master Dec 29, 2021
@yycptt yycptt deleted the fix-queue-diff-metric branch December 29, 2021 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants