Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use persistence config consistency for schema version check #2291

Merged
merged 1 commit into from
Dec 14, 2021
Merged

Use persistence config consistency for schema version check #2291

merged 1 commit into from
Dec 14, 2021

Conversation

wxing1292
Copy link
Contributor

What changed?

  • Use persistence config consistency for Cassandra schema version checking
  • Update CQL schema tools accordingly

Why?
Should use persistence consistency from config or input

How did you test it?
N/A

Potential risks
N/A

Is hotfix candidate?
No

* Use persisence config consistency for Cassandra schema version checking
* Upddate CQL schema tools accordingly
@wxing1292 wxing1292 requested review from a team, feedmeapples and yiminc December 12, 2021 00:54
Copy link
Member

@yiminc yiminc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is not required arg, where do we set the default if it is not present?

@wxing1292
Copy link
Contributor Author

I assume this is not required arg, where do we set the default if it is not present?

default should be empty string, then persistence config parsing will use local quorum:
https://github.com/temporalio/temporal/blob/v1.13.1/common/config/persistence.go#L150

@wxing1292 wxing1292 merged commit adf5747 into temporalio:master Dec 14, 2021
@wxing1292 wxing1292 deleted the cass-schema-version-consistency branch December 14, 2021 21:42
wxing1292 added a commit that referenced this pull request Dec 14, 2021
* Use persistence config consistency for Cassandra schema version checking
* Update CQL schema tools accordingly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants