Add tzdata to server base image and binary #2277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
approved these changes
Dec 10, 2021
| @@ -5,7 +5,7 @@ To build a new version of base docker image run: | |||
| make <base_image_name> DOCKER_IMAGE_TAG=<new_base_image_version> | |||
| ``` | |||
|
|
|||
| Check [MakeFile](Makefile) for all possible `base_image_name` options. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
This adds
tzdatato the server base image (as an Alpine package), so it will end up in the built server images. It also adds embeddedtzdatato the server binary as a fallback (using Go's time/tzdata package), in case the binary is run in another context. In general we expect the Alpine package to be more up-to-date than Go's embeddedtzdata(currently 2021e vs 2021a).Why?
So the server can do time zone calculations.
How did you test it?
Built images + binaries.
Potential risks
No risks.
Is hotfix candidate?
No.