Add custom logger option to schema tool #1943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
requested changes
Sep 20, 2021
jlegrone
force-pushed
the
jlegrone/schema-logger
branch
from
cf827a5 to
8fb4b6f
Compare
yiminc
approved these changes
Sep 20, 2021
|
So there are no usages of |
alexshtin
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added a logger configuration option to the schema migration tool. This enables filtering and reformatting of migration logs.
Why?
The existing schema migration logs can be noisy, particularly when they are mixed in with test logs (as is the case in
temporalite). This also makes it possible to output structured logs, which are typically easier to integrate with third party log aggregation services.How did you test it?
Validated by adding a local override for
go.temporal.io/serverin the go.mod oftemporaliteand running migrations against sqlite.Potential risks
The logs produced by the schema tool now default to a different format. This format is determined by the
log.NewCLILogger()function.Is hotfix candidate?
no