Dedup SignalWithStart based on RequestId (#2356)

temporalio · Jan 7, 2022 · d01b1c7 · d01b1c7
1 parent cf6c03e
commit d01b1c7
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/service/history/historyEngine.go b/service/history/historyEngine.go
@@ -1960,6 +1960,13 @@ func (e *historyEngineImpl) SignalWithStartWorkflowExecution(
 				return nil, consts.ErrSignalsLimitExceeded
 			}
 
+			if sRequest.GetRequestId() != "" && mutableState.IsSignalRequested(sRequest.GetRequestId()) {
+				// duplicate signal
+				return &historyservice.SignalWithStartWorkflowExecutionResponse{RunId: context.GetExecution().RunId}, nil
+			}
+			if sRequest.GetRequestId() != "" {
+				mutableState.AddSignalRequested(sRequest.GetRequestId())
+			}
 			if _, err := mutableState.AddWorkflowExecutionSignaled(
 				sRequest.GetSignalName(),
 				sRequest.GetSignalInput(),
@@ -2076,6 +2083,9 @@ func (e *historyEngineImpl) SignalWithStartWorkflowExecution(
 	}
 
 	// Add signal event
+	if sRequest.GetRequestId() != "" {
+		mutableState.AddSignalRequested(sRequest.GetRequestId())
+	}
 	if _, err := mutableState.AddWorkflowExecutionSignaled(
 		sRequest.GetSignalName(),
 		sRequest.GetSignalInput(),