Handle SQL duplicate key case (#2410)

* Correctly handle retry of history node / tree query
temporalio · Jan 24, 2022 · 87dc0ef · 87dc0ef
1 parent 3377e64
commit 87dc0ef
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/common/persistence/sql/history_store.go b/common/persistence/sql/history_store.go
@@ -100,8 +100,8 @@ func (m *sqlExecutionStore) AppendHistoryNodes(
 		if err != nil {
 			return err
 		}
-		if rowsAffected != 1 {
-			return fmt.Errorf("expected 1 row to be affected for node table, got %v", rowsAffected)
+		if !(rowsAffected == 1 || rowsAffected == 2) {
+			return fmt.Errorf("expected 1 or 2 row to be affected for node table, got %v", rowsAffected)
 		}
 
 		result, err = tx.InsertIntoHistoryTree(ctx, treeRow)
@@ -309,8 +309,8 @@ func (m *sqlExecutionStore) ForkHistoryBranch(
 	if err != nil {
 		return err
 	}
-	if rowsAffected != 1 {
-		return fmt.Errorf("expected 1 row to be affected for tree table, got %v", rowsAffected)
+	if !(rowsAffected == 1 || rowsAffected == 2) {
+		return fmt.Errorf("expected 1 or 2 row to be affected for tree table, got %v", rowsAffected)
 	}
 	return nil
 }