Unload shard when ownership lost (#2355)

temporalio · Jan 7, 2022 · 5efdf07 · 5efdf07
1 parent 9ca8598
commit 5efdf07
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/service/history/shard/controller_impl.go b/service/history/shard/controller_impl.go
@@ -383,8 +383,10 @@ func (c *ControllerImpl) acquireShards() {
 								c.contextTaggedLogger.Error("Unable to create history shard context", tag.Error(err), tag.OperationFailed, tag.ShardID(shardID))
 							}
 							cancel()
+						} else {
+							// current host is not owner of shard, unload it if it is already loaded.
+							c.CloseShardByID(shardID)
 						}
-						// TODO: If we're _not_ the owner for this shard, and we have it loaded, we should unload it.
 					}
 				}
 			}