Skip to content

Commit

Permalink
Exclude taskAlreadyStarted error from history client logging (#3376)
Browse files Browse the repository at this point in the history
  • Loading branch information
yycptt authored Sep 13, 2022
1 parent b812e8e commit 574228e
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion client/history/metric_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ import (
"go.temporal.io/server/common/log"
"go.temporal.io/server/common/log/tag"
"go.temporal.io/server/common/metrics"
serviceerrors "go.temporal.io/server/common/serviceerror"
)

var _ historyservice.HistoryServiceClient = (*metricClient)(nil)
Expand Down Expand Up @@ -84,7 +85,8 @@ func (c *metricClient) finishMetricsRecording(
*serviceerror.QueryFailed,
*serviceerror.NamespaceNotFound,
*serviceerror.WorkflowNotReady,
*serviceerror.WorkflowExecutionAlreadyStarted:
*serviceerror.WorkflowExecutionAlreadyStarted,
*serviceerrors.TaskAlreadyStarted:
// noop - not interest and too many logs
default:
c.throttledLogger.Info("history client encountered error", tag.Error(err), tag.ErrorType(err))
Expand Down

0 comments on commit 574228e

Please sign in to comment.