Skip to content

Commit

Permalink
Renamed InternalWorkflowSnapshot.ExecutionInfo to ExecutionInfoBlob. (#…
Browse files Browse the repository at this point in the history
…2384)

This matches the convention with ExecutionState/ExecutionStateBlob and allows us to add an ExecutionInfo proto.
  • Loading branch information
Jason Roselander authored Jan 18, 2022
1 parent 71093d7 commit 24ca4e8
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
6 changes: 3 additions & 3 deletions common/persistence/cassandra/util.go
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ func applyWorkflowSnapshotBatchAsReset(
namespaceID,
workflowID,
runID,
workflowSnapshot.ExecutionInfo,
workflowSnapshot.ExecutionInfoBlob,
workflowSnapshot.ExecutionState,
workflowSnapshot.ExecutionStateBlob,
workflowSnapshot.NextEventID,
Expand Down Expand Up @@ -386,8 +386,8 @@ func createExecution(
snapshot.WorkflowID,
snapshot.RunID,
rowTypeExecution,
snapshot.ExecutionInfo.Data,
snapshot.ExecutionInfo.EncodingType.String(),
snapshot.ExecutionInfoBlob.Data,
snapshot.ExecutionInfoBlob.EncodingType.String(),
snapshot.ExecutionStateBlob.Data,
snapshot.ExecutionStateBlob.EncodingType.String(),
snapshot.NextEventID,
Expand Down
2 changes: 1 addition & 1 deletion common/persistence/execution_manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -586,7 +586,7 @@ func (m *executionManagerImpl) SerializeWorkflowSnapshot(
NextEventID: input.NextEventID,
}

result.ExecutionInfo, err = m.serializer.WorkflowExecutionInfoToBlob(input.ExecutionInfo, enumspb.ENCODING_TYPE_PROTO3)
result.ExecutionInfoBlob, err = m.serializer.WorkflowExecutionInfoToBlob(input.ExecutionInfo, enumspb.ENCODING_TYPE_PROTO3)
if err != nil {
return nil, err
}
Expand Down
2 changes: 1 addition & 1 deletion common/persistence/persistenceInterface.go
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,7 @@ type (
WorkflowID string
RunID string

ExecutionInfo *commonpb.DataBlob
ExecutionInfoBlob *commonpb.DataBlob
ExecutionState *persistencespb.WorkflowExecutionState
ExecutionStateBlob *commonpb.DataBlob
StartVersion int64
Expand Down
2 changes: 1 addition & 1 deletion common/persistence/size.go
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ func statusOfInternalWorkflowSnapshot(
return nil
}

executionInfoSize := sizeOfBlob(snapshot.ExecutionInfo)
executionInfoSize := sizeOfBlob(snapshot.ExecutionInfoBlob)
executionStateSize := sizeOfBlob(snapshot.ExecutionStateBlob)

activityInfoCount := len(snapshot.ActivityInfos)
Expand Down
4 changes: 2 additions & 2 deletions common/persistence/sql/execution_util.go
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ func applyWorkflowSnapshotTxAsReset(
tx,
namespaceID,
workflowID,
workflowSnapshot.ExecutionInfo,
workflowSnapshot.ExecutionInfoBlob,
workflowSnapshot.ExecutionState,
workflowSnapshot.NextEventID,
lastWriteVersion,
Expand Down Expand Up @@ -433,7 +433,7 @@ func (m *sqlExecutionStore) applyWorkflowSnapshotTxAsNew(
tx,
namespaceID,
workflowID,
workflowSnapshot.ExecutionInfo,
workflowSnapshot.ExecutionInfoBlob,
workflowSnapshot.ExecutionState,
workflowSnapshot.NextEventID,
lastWriteVersion,
Expand Down

0 comments on commit 24ca4e8

Please sign in to comment.