Add validation for invalid starttime filter for standard visibility (#…

…2401)
temporalio · Jan 21, 2022 · 1e19178 · 1e19178
1 parent aa69178
commit 1e19178
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/common/persistence/visibility/store/standard/converter_test.go b/common/persistence/visibility/store/standard/converter_test.go
@@ -61,6 +61,7 @@ var unsupportedQuery = []string{
 	`ExecutionStatus = "Running" AND WorkflowType = "xyz"`,
 	`WorkflowID = "abc" OR WorkflowType = "xyz"`,
 	`WorkflowID != "abc"`,
+	`StartTime < "2022-01-15T05:43:12.74127Z"`,
 }
 
 func TestSupportedQueryFilters(t *testing.T) {

diff --git a/common/persistence/visibility/store/standard/query_interceptors.go b/common/persistence/visibility/store/standard/query_interceptors.go
@@ -98,6 +98,10 @@ func (vi *valuesInterceptor) Values(name string, values ...interface{}) ([]inter
 		}
 		return values, err
 	case searchattribute.StartTime:
+		if len(values) != 2 {
+			return nil, query.NewConverterError("StartTime only supports BETWEEN ... AND ... filter")
+		}
+
 		values, err := vi.nextInterceptor.Values(name, values...)
 		if err == nil {
 			minTime, err := time.Parse(time.RFC3339Nano, values[0].(string))