Add namespace to search attributes operations requests #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigozhou
force-pushed
the
add-ns-sa-operations
branch
from
b9fdc78 to
20d2e16
Compare
feedmeapples
reviewed
Feb 4, 2023
| @@ -148,7 +148,7 @@ func populateFlagsFunc(command *cli.Command, globalFlags []cli.Flag) func(ctx *c | |||
|
|
|||
| for _, c := range ctx.Lineage() { | |||
| if !c.IsSet(name) { | |||
| value := tctlConfig.EnvProperty(tctlConfig.CurrentEnv, name) | |||
| value, _ := tctlConfig.EnvProperty(tctlConfig.CurrentEnv, name) | |||
There was a problem hiding this comment.
oh i wouldn't really upgrade tctl-kit since in the latest versions it has breaking changes (focusing on Temporal single binary). Though again i also wanted to completely remove tctl-next code from here so tctl-kit is not even imported. Just pushed the deprecation message #342
There was a problem hiding this comment.
@feedmeapples
What's the status of deprecating? I need to add this to next release of tctl to work with Server v1.20.
Can I merge this first?
There was a problem hiding this comment.
currently there is a notice in --help text output. tctl next code is unlikely to be removed asap so approving the PR
rodrigozhou
force-pushed
the
add-ns-sa-operations
branch
from
20d2e16 to
4532cb5
Compare
feedmeapples
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Upgraded API to v1.16.0.
Upgraded Server to master.
Updated search attributes operations to require namespace argument.
Why?
Namespace argument will become required for doing all search attributes operations.
Checklist
Closes
How was this tested:
Launched server, and ran commands to add/remove/list search attributes.