change syscall.Exec for command.Run to avoid a complete replacement of the current Go process with another #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f the current Go process with another
|
|
feedmeapples
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
change syscall.Exec for command.Run to avoid a complete replacement of the current Go process with another for external plugin execution.
Fixes #321
Why?
If I register a headers provider plugin, this plugin will be spawn and started. Then I execute an external plugin, the current code will replace the current Go process with another by calling syscall.Exec. The side effect is that the app.After will never be called and the header provide plugin will stay and will not be stopped
Checklist
Closes
[Bug] Running external plugin will leave processes started like header provider plugin running #321
How was this tested
export TEMPORAL_CLI_PLUGIN_HEADERS_PROVIDER=tctl-authorization
tctl yo
check that tctl-authorization is not running anymore