Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform Namespace --cluster + args into a slice #295

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

feedmeapples
Copy link
Contributor

@feedmeapples feedmeapples commented Sep 28, 2022

What was changed

  • Changed namespace --cluster plus cluster args into a slice

Why?

previous syntax for clusters was pretty ugly. It was requiring to set --cluster to specify just one cluster name, then the args[1:] would mean the rest of the cluster (after namespace arg)

before

tctl namespace register --cluster active my-namespace standby

after

tctl namespace register --cluster active --cluster standby my-namespace  

Checklist

  1. Closes

  2. How was this tested:

added unit test

  1. Any docs updates needed?

@feedmeapples feedmeapples changed the base branch from main to update-flags September 28, 2022 04:36
@feedmeapples feedmeapples changed the title Namespace cluster slice Transform Namespace --cluster + args into a slice Sep 28, 2022
Base automatically changed from update-flags to main September 28, 2022 04:41
@feedmeapples feedmeapples force-pushed the namespace-cluster-slice branch from 6be6520 to 58fa00c Compare September 28, 2022 04:48
@feedmeapples feedmeapples force-pushed the namespace-cluster-slice branch from 58fa00c to f256727 Compare September 28, 2022 04:57
@feedmeapples feedmeapples merged commit 1746cb6 into main Sep 28, 2022
@feedmeapples feedmeapples deleted the namespace-cluster-slice branch September 28, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants