Add tctl schedule commands #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The diff for the test failure is --- a 2022-06-08 10:12:16.229019661 -0700
+++ b 2022-06-08 10:12:19.623037407 -0700
@@ -1,6 +1,7 @@
"{EventId:1, EventType:WorkflowExecutionStarted, Version:0, TaskId:0,"
"Attributes:{WorkflowExecutionStartedEventAttributes:{WorkflowType:{Name:helloworldWorkflow},"
"ParentInitiatedEventId:0, TaskQueue:{Name:taskQueue, Kind:Unspecified},"
-"Input:[\"LongTextLongTextLongTextLongTextLongTextLongTextLongTextLongTextLongTextLongTextLongText ... ongTextLongText"
-"LongTextLongTextLongTextLongTextLongTextLongTextLongTextLongTextLongTextLongTextLongTextLongTextLongTextLongTextLongText"
-" LongText\"], WorkflowRunTimeout:1m0s, WorkflowTaskTimeout:10s, Initiator:Unspecified, Identity:tester, Attempt:0}}}"
+"Input:[\"LongTextLongTextLongTextLongTextLongTextLongTextLongTextLongTextLongTextLongTextLongText ..."
+"tLongTextLongTextLongTextLongTextLongTextLongTextLongTextLongTextLongTextLongTextLongTextLongTextLongText"
+"LongText\"], WorkflowRunTimeout:1m0s, WorkflowTaskTimeout:10s, Initiator:Unspecified, Identity:tester,"
+"Attempt:0, ParentInitiatedEventVersion:0}}}"I think the api bump added the ParentInitiatedEventVersion field and that threw things off? It looks correct so I'm just going to update the test. |
feedmeapples
reviewed
Jun 8, 2022
feedmeapples
reviewed
Jun 8, 2022
feedmeapples
reviewed
Jun 8, 2022
cli/schedule.go
Outdated
| Required: true, | ||
| } | ||
| overlap := &cli.StringFlag{ | ||
| Name: FlagOverlapPolicy, |
There was a problem hiding this comment.
is this currently not used?
There was a problem hiding this comment.
it is used, for create and update
feedmeapples
reviewed
Jun 8, 2022
| &cli.StringSliceFlag{ | ||
| Name: FlagCalendar, | ||
| Aliases: FlagCalendarAlias, | ||
| Usage: `Calendar specification in JSON, e.g. {"dayOfWeek":"Fri","hour":"17","minute":"5"}`, |
There was a problem hiding this comment.
do we have docs for this? if yes we can add a link right here for details
There was a problem hiding this comment.
docs aren't written yet. it's coming up soon on my list of stuff to do. we can add a link later.
also, commas won't work in this field until we fix the cli issue I mentioned
feedmeapples
reviewed
Jun 8, 2022
feedmeapples
reviewed
Jun 8, 2022
feedmeapples
reviewed
Jun 8, 2022
feedmeapples
reviewed
Jun 8, 2022
feedmeapples
reviewed
Jun 8, 2022
feedmeapples
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Adding tctl commands for manipulating schedules.
Why?
This is one of two main interfaces to the feature.
Checklist
Closes
How was this tested:
tested manually
Any docs updates needed?
yes, doc updates coming soon