Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print Workflow Type and Status when printing workflows #201

Merged
merged 1 commit into from
May 18, 2022
Merged

Print Workflow Type and Status when printing workflows #201

merged 1 commit into from
May 18, 2022

Conversation

feedmeapples
Copy link
Contributor

@feedmeapples feedmeapples commented May 18, 2022 •
edited
Loading

What was changed

  • Adds workflow status
  • Removes ExecutionTime from the --fields long output to fit ~1920* px screen
./tctl w l                                                                                                                    INT ✘ 
    Status          WorkflowId                  Name               StartTime     
  Running     f0f0aa_Running          RainbowStatusesWorkflow    11 minutes ago  
  TimedOut    f0f0aa_TimedOut         RainbowStatusesWorkflow    11 minutes ago  
  Completed   f0f0aa_ContinuedAsNew   RainbowStatusesWorkflow    11 minutes ago  
  Terminated  f0f0aa_Terminated       RainbowStatusesWorkflow    11 minutes ago  
  Failed      f0f0aa_Failed           RainbowStatusesWorkflow    11 minutes ago  
  Canceled    f0f0aa_Canceled         RainbowStatusesWorkflow    11 minutes ago  
  Completed   f0f0aa_Completed        RainbowStatusesWorkflow    11 minutes ago  
  Completed   largepayload_ce7c_2     LargePayloadWorkflow       15 minutes ago  
  Completed   largepayload_ce7c_3     LargePayloadWorkflow       15 minutes ago  
  Completed   largepayload_ce7c_5     LargePayloadWorkflow       15 minutes ago  
  Completed   largepayload_ce7c_4     LargePayloadWorkflow       15 minutes ago

Why?

  • Since switching to ListWorkflowExecutions API, the command now prints workflows of any status by default and printing this info is useful
  • Default output now closer matches the fields that we print in UI

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@feedmeapples feedmeapples force-pushed the print-workflow-status branch from 2478a4f to e76ea66 Compare May 18, 2022 17:12
@feedmeapples feedmeapples force-pushed the print-workflow-status branch from e76ea66 to e42a577 Compare May 18, 2022 17:18
@feedmeapples feedmeapples changed the title Add Status column when printing workflows Print Workflow Type and Status when printing workflows May 18, 2022
@feedmeapples feedmeapples merged commit 4190eeb into main May 18, 2022
@feedmeapples feedmeapples deleted the print-workflow-status branch May 18, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevekinney stevekinney stevekinney approved these changes

@bergundy bergundy bergundy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@feedmeapples @bergundy @stevekinney