Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move workflow observe under show command as a flag #190

Merged
merged 2 commits into from
May 9, 2022
Merged

Move workflow observe under show command as a flag #190

merged 2 commits into from
May 9, 2022

Conversation

feedmeapples
Copy link
Contributor

@feedmeapples feedmeapples commented Apr 30, 2022 •
edited
Loading

What was changed

  • Removed workflow observe command
  • added it under workflow show as a --follow flag

Why?

~ same command

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@feedmeapples feedmeapples requested a review from bergundy May 2, 2022 15:56
bergundy
bergundy approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@bergundy bergundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if we want a separate flag to also follow runs in case of continue as new like how the sdk gets a result

@feedmeapples feedmeapples merged commit 513455b into main May 9, 2022
@feedmeapples feedmeapples deleted the merge-show-observe branch May 9, 2022 01:45
bergundy
bergundy reviewed May 9, 2022
View reviewed changes
cli/flags.go
@@ -267,6 +268,11 @@ var flagsForShowWorkflow = []cli.Flag{
Name: FlagResetPointsOnly,
Usage: "Only show events that are eligible for reset",
},
&cli.BoolFlag{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that -f works too?

Copy link
Contributor Author

@feedmeapples feedmeapples May 10, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--follow would work. -f is not set as an alias yet

@feedmeapples
Copy link
Contributor Author

Wondering if we want a separate flag to also follow runs in case of continue as new like how the sdk gets a result

could you file an issue for this

@bergundy bergundy mentioned this pull request May 19, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergundy bergundy bergundy approved these changes

@stevekinney stevekinney stevekinney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@feedmeapples @bergundy @stevekinney