Support binary values in gRPC metadata #348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-olszewski
approved these changes
Oct 3, 2025
temporalio/ext/src/client.rs
Outdated
| format!("Value for metadata key {key} must be ASCII-8BIT"), | ||
| )); | ||
| } | ||
| binary_headers.insert(key, unsafe { value.as_slice() }.to_vec()); |
There was a problem hiding this comment.
It might make sense to move to_vec into unsafe block to prevent ever accidentally holding onto the slice reference.
Suggested change
| binary_headers.insert(key, unsafe { value.as_slice() }.to_vec()); | |
| binary_headers.insert(key, unsafe { value.as_slice().to_vec() }); |
There was a problem hiding this comment.
Makes sense. I tend to take the "smallest amount of unsafe possible" approach, but it makes sense here to not carry a ref over the boundary. If I need another commit, I'll make this change too.
Sushisource
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Need to support
-binvalues as binary values in gRPCChecklist