Add getter for ActivityPrototype::$factory #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
wolfy-j
approved these changes
Aug 30, 2024
roxblnfk
force-pushed
the
getter-for-factory
branch
from
4fd9502 to
d767863
Compare
roxblnfk
force-pushed
the
getter-for-factory
branch
from
d767863 to
8b288ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Adding a getter for ActivityPrototype::$factory
Why?
Whenever I start my workers, I replace all
ActivityPrototypewith a decorated version of my activities. I do this to add support for EventDispatcher. Ie I dispatch event before and after an activity is executed.So I need to rebuild the
ActivityPrototype.Checklist
How was this tested:
Unit tests
Any docs updates needed?
Nope