Add getCurrentUpdateInfo #2158
Merged
Add getCurrentUpdateInfo #2158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quinn-With-Two-Ns
force-pushed
the
issue-2093
branch
from
6a29409
to
be38203
Compare
Sushisource
approved these changes
Jul 30, 2024
Comment on lines
345
to
356
| * <p>Note: Should only be called within the context of a workflow. | ||
| * | ||
| * @return current workflow info. | ||
| */ | ||
| public static WorkflowInfo getInfo() { | ||
| return WorkflowInternal.getWorkflowInfo(); | ||
| } | ||
|
|
||
| /** | ||
| * Returns information about current workflow update. | ||
| * | ||
| * <p>Note: Should only be called within the context of a update handler thread in a workflow. |
There was a problem hiding this comment.
I might change both of these notes to "only returns non-null / filled option within the context.."
There was a problem hiding this comment.
They actually throw an error if called outside a workflow context
There was a problem hiding this comment.
Ah, ok, even better to say that then
| @Override | ||
| public String update(Integer index, String value) { | ||
| UpdateInfo updateInfo = Workflow.getCurrentUpdateInfo().get(); | ||
| Workflow.sleep(Duration.ofMillis(100)); |
There was a problem hiding this comment.
No, not for the test. I was thinking making the handler take more then one WFT would provide better coverage. Not sure if that is really true though.
Quinn-With-Two-Ns
force-pushed
the
issue-2093
branch
2 times, most recently
from
d60d99a
to
9ae2781
Compare
Quinn-With-Two-Ns
force-pushed
the
issue-2093
branch
from
9ae2781
to
22a2ba9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
getCurrentUpdateInfo().closes #2093